Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade kubeadm to 1.22 #864

Merged
merged 1 commit into from
Jun 5, 2022
Merged

upgrade kubeadm to 1.22 #864

merged 1 commit into from
Jun 5, 2022
+2,128 −703

Conversation

huiwq1990
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

Prepare for yurtadm token subcommand.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

@openyurt-bot
Copy link
Collaborator

@huiwq1990: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

Prepare for yurtadm token subcommand.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/feature kind/feature label May 31, 2022
@openyurt-bot openyurt-bot requested review from DrmagicE and Peeknut May 31, 2022 16:22
@rambohe-ch
Copy link
Member

/assign @lonelyCZ @Congrool PTAL

@Congrool
Copy link
Member

Congrool commented Jun 1, 2022

For tracing the origin of these introduced code in the future, could you please give some information in this PR about where these code copied from, including the commit/tag of kubernetes and the paths of original file? @huiwq1990

Congrool
Congrool reviewed Jun 1, 2022
View reviewed changes
pkg/util/kubernetes/kubeadm/app/cmd/options/yurtoptions.go Outdated

// KubernetesResourceServer flag sets the address for download k8s node resources.
KubernetesResourceServer = "kubernetes-resource-server"
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd better make pkg/util/kubernetes only contain code what introduced from kubernetes. For code that will be used by yurtadm, we can move them to pkg/yurtadm/constants.

@huiwq1990
Copy link
Member Author

For tracing the origin of these introduced code in the future, could you please give some information in this PR about where these code copied from, including the commit/tag of kubernetes and the paths of original file? @huiwq1990

@Congrool The code I fork is release-1.22, and the commit is kubernetes/kubernetes@67a57c4

@Congrool
Copy link
Member

Congrool commented Jun 1, 2022 •
edited
Loading

@huiwq1990 How about using code of v1.22.3, because other introduced packages are from this version. See go.mod

@huiwq1990
Copy link
Member Author

Yes, it's better use that version, i will fix it later.

@huiwq1990 huiwq1990 force-pushed the feat-kubeadm branch 2 times, most recently from b1357be to 4ce4f82 Compare June 2, 2022 01:43
@Congrool
Copy link
Member

Congrool commented Jun 4, 2022

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Jun 4, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huiwq1990, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Jun 5, 2022
@rambohe-ch rambohe-ch merged commit 8204290 into openyurtio:master Jun 5, 2022
@windydayc windydayc mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Congrool Congrool Congrool left review comments

@rambohe-ch rambohe-ch rambohe-ch approved these changes

@DrmagicE DrmagicE Awaiting requested review from DrmagicE

@Peeknut Peeknut Awaiting requested review from Peeknut

Assignees

@Congrool Congrool

Labels
approved approved kind/feature kind/feature lgtm lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huiwq1990 @openyurt-bot @rambohe-ch @Congrool